add offset to Waypoint so new dweets load before scrolling to the bot… #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! The changes look sensible, and when I get a chance to test them I'll merge and deploy if I don't run into any issues. |
|
Great! Love the site. Happy to contribute. |
|
Apologies that I never got around to properly testing and merging this contribution. But since we are now moving to a new frontend ( https://github.com/dwitter-net/dwitter-frontend/ ), I'm closing this. Again, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tom.
When opening your Pull Request, we encourage you to do the following (you can add an X to check each task):
make lintto ensure that all the files are formatted and using best practices.should trigger load of dweet list before reaching the absolute bottom of the current buffer #436