Fixes #518: lsquic compliance with RFC 9000 for MAX_STREAM_DATA frame #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild successfully upon latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The story begins here:
#518.
The bug is:
The function
process_max_stream_data_frame()returns an error if it detects that the corresponding stream has not been created, causing LSQUIC to close the connection.According to RFC9000:
If this stream is initiated by peer, the local side should create the receiving part of the stream and transition to the Recv state upon receiving a max_stream_data frame (similar to how process_stream_frame() handles it).
If this stream is initiated by local side, the local side should consider it as a connection error of type STREAM_STATE_ERROR.
We submitted the solution according to RFC9000.