-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace starlette.datastructures.Headers and other MultiDict-like structures with aio-libs/multidict #640
Comments
It occurs to me we can create our own version using https://docs.python.org/3/library/collections.html#collections.ChainMap This has the advantage if being both fast and a builtin. It's not a multidict, but we can use it as a basis. Thoughts? |
We could, but I'm not sure if we should. I don't think it's that fast, certainly not faster than the proposed multidict. And we'd have to add most of the implementation, not sure if there's really any benefit to using |
Nothing genius I'm afraid. Let's stick with multidicting This |
I had this on my plate already, unless @jtraub wants to take this on I'd take care of it in the following days? |
Implemented in #732 |
As a part of migration from Starlette we should replace
starlette.datastructures.Headers
,starlette.datastructures.MutableHeaders
andstarlette.datastructures.ImmutableMultiDict
with another multidict implementation.Proposed library is multidict
Convenient usage list for mentioned classes can be found in #634
Related issue in starlite-multipart tracker - litestar-org/starlite-multipart#5
The text was updated successfully, but these errors were encountered: