Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace starlettes Headers and MutableHeaders, move FormMultiDict to multidict #732

Merged
merged 18 commits into from
Nov 2, 2022
Merged

Replace starlettes Headers and MutableHeaders, move FormMultiDict to multidict #732

merged 18 commits into from
Nov 2, 2022

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Nov 1, 2022 •
edited
Loading

This is part of #640 and replaces starlette's Headers with our own multidict-based version, and MutableHeaders with an version adapted from starlette

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@provinzkraut provinzkraut changed the base branch from add-multidict to main November 1, 2022 14:21
Goldziher
Goldziher reviewed Nov 1, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
Goldziher
Goldziher reviewed Nov 1, 2022
View reviewed changes
Copy link
Contributor

@Goldziher Goldziher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting some discussion in slack.

provinzkraut and others added 4 commits November 2, 2022 13:44
@provinzkraut @Goldziher
Update starlite/utils/deprecation.py
1580cf4 
Co-authored-by: Na'aman Hirschfeld <[email protected]>
@provinzkraut @Goldziher
Update pyproject.toml
834d9c6 
Co-authored-by: Na'aman Hirschfeld <[email protected]>
@provinzkraut
Add default for removal_in
d4b5fc1
@provinzkraut
Replace FormMultiDict (#734)
53fc909 
* Move FormMultiDict to multidict
@provinzkraut provinzkraut changed the title Replace starlettes Headers and MutableHeaders Replace starlettes Headers and MutableHeaders, move FormMultiDict to multidict Nov 2, 2022
@provinzkraut provinzkraut added this to the starlette-migration milestone Nov 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.9% 91.9% Coverage
0.0% 0.0% Duplication

@provinzkraut provinzkraut merged commit c81c523 into main Nov 2, 2022
@provinzkraut provinzkraut deleted the replace-headers branch November 2, 2022 14:22
This was referenced Nov 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goldziher Goldziher Goldziher approved these changes

@jtraub jtraub jtraub approved these changes

@seladb seladb Awaiting requested review from seladb

@cofin cofin Awaiting requested review from cofin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
starlette-migration
Development

Successfully merging this pull request may close these issues.
3 participants
@provinzkraut @jtraub @Goldziher