Update ASGI router #644
Merged
Update ASGI router #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goldziher
added
Enhancement
Goldziher
requested review from
jtraub,
cofin,
seladb,
peterschutt,
provinzkraut and
infohash
|
related to #634 |
provinzkraut
approved these changes
Oct 23, 2022
|
This pull request introduces 1 alert when merging 62c0b69 into e76e6fd - view on LGTM.com new alerts:
|
Goldziher
added a commit
that referenced
this pull request
Oct 23, 2022
* removed starlette dependency for lifespan events * updated tests * fix async callable * added cookie parser (#645) * added cookie parser * address review comments * Replace get name (#646) * add get_name helper * added helper to handle enum * update enum safeguard * Removed starlette HTTPException as code dependency (#647) * removed starlette HTTPException as code dependency * address review comments
|
Kudos, SonarCloud Quality Gate passed! |
Goldziher
added a commit
that referenced
this pull request
Oct 23, 2022
* removed starlette dependency for lifespan events * updated tests * fix async callable * added cookie parser (#645) * added cookie parser * address review comments * Replace get name (#646) * add get_name helper * added helper to handle enum * update enum safeguard * Removed starlette HTTPException as code dependency (#647) * removed starlette HTTPException as code dependency * address review comments
Goldziher
added a commit
that referenced
this pull request
Oct 23, 2022
* removed starlette dependency for lifespan events * updated tests * fix async callable * added cookie parser (#645) * added cookie parser * address review comments * Replace get name (#646) * add get_name helper * added helper to handle enum * update enum safeguard * Removed starlette HTTPException as code dependency (#647) * removed starlette HTTPException as code dependency * address review comments
Goldziher
added a commit
that referenced
this pull request
Oct 23, 2022
* removed starlette dependency for lifespan events * updated tests * fix async callable * added cookie parser (#645) * added cookie parser * address review comments * Replace get name (#646) * add get_name helper * added helper to handle enum * update enum safeguard * Removed starlette HTTPException as code dependency (#647) * removed starlette HTTPException as code dependency * address review comments
Goldziher
added a commit
that referenced
this pull request
Oct 23, 2022
* initial * updated folder structure * add file response * added tests * add anyio * cleanup tests * cleanup * finished test coverage * added docstrings * updated reference docs * updated docs * Update docs/usage/16-templating/2-template-functions.md Co-authored-by: Peter Schutt <[email protected]> * Update starlite/response/base.py Co-authored-by: Peter Schutt <[email protected]> * addressed review comments * cleanup imports * updated response containers * addressed review comment * updated response containers missing args * updated tests * fix bound variable * fixed typing * fix bound variable * removed constraint * update docstrings * update coverage * Update ASGI router (#644) * removed starlette dependency for lifespan events * updated tests * fix async callable * added cookie parser (#645) * added cookie parser * address review comments * Replace get name (#646) * add get_name helper * added helper to handle enum * update enum safeguard * Removed starlette HTTPException as code dependency (#647) * removed starlette HTTPException as code dependency * address review comments * Replace background tasks (#652) * updated background tasks * updated test and docs * address review comment * fix lgtm issues and cleanup * addressed review comments * updated tests Co-authored-by: Peter Schutt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
CONTRIBUTING.md?This PR removes the dependency on Starlette to handle "lifespan" events. Its part of #612