Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace starlette URL, URLPath and Address #738

Merged
merged 20 commits into from
Nov 8, 2022
Merged

Replace starlette URL, URLPath and Address #738

merged 20 commits into from
Nov 8, 2022

Conversation

provinzkraut
Copy link
Member

@provinzkraut provinzkraut commented Nov 2, 2022 •
edited
Loading

PR Checklist

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you got 100% test coverage on new code?
  • Have you updated the prose documentation?
  • Have you updated the reference documentation?

@provinzkraut provinzkraut added this to the starlette-migration milestone Nov 2, 2022
@provinzkraut provinzkraut mentioned this pull request Nov 2, 2022
Closed
@provinzkraut provinzkraut linked an issue Nov 2, 2022 that may be closed by this pull request
Enhancment: Replace starlette's URL, URLPath and Address with our own implementation #667
Closed
@provinzkraut provinzkraut force-pushed the replace-starlette-url branch from 778f887 to cec8e1e Compare November 8, 2022 11:52
@provinzkraut provinzkraut marked this pull request as ready for review November 8, 2022 11:57
Goldziher
Goldziher approved these changes Nov 8, 2022
View reviewed changes
docs/reference/datastructures/7-multi-dicts.md Outdated Show resolved Hide resolved
starlite/datastructures/__init__.py Show resolved Hide resolved
starlite/datastructures/multi_dicts.py Show resolved Hide resolved
starlite/datastructures/url.py Show resolved Hide resolved
starlite/datastructures/url.py Outdated Show resolved Hide resolved
starlite/datastructures/url.py Outdated Show resolved Hide resolved
starlite/datastructures/url.py Outdated Show resolved Hide resolved
starlite/datastructures/url.py Outdated Show resolved Hide resolved
starlite/datastructures/url.py Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@provinzkraut provinzkraut merged commit f5f932f into main Nov 8, 2022
@provinzkraut provinzkraut deleted the replace-starlette-url branch November 8, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goldziher Goldziher Goldziher approved these changes

@peterschutt peterschutt Awaiting requested review from peterschutt

@jtraub jtraub Awaiting requested review from jtraub

@cofin cofin Awaiting requested review from cofin

@infohash infohash Awaiting requested review from infohash

@seladb seladb Awaiting requested review from seladb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
starlette-migration
Development

Successfully merging this pull request may close these issues.

Enhancment: Replace starlette's URL, URLPath and Address with our own implementation
2 participants
@provinzkraut @Goldziher