add QueryMultiDict
#759
Merged
add QueryMultiDict
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschutt
approved these changes
Nov 6, 2022
|
@Goldziher Let me know what the outcome of your tests is. If it looks good, I'll incorporate it into #667 |
…ctionquery_params
provinzkraut
reviewed
Nov 7, 2022
provinzkraut
reviewed
Nov 7, 2022
Goldziher
deleted the
742-enhancment-use-a-multidict-for-asgiconnectionquery_params
branch
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
CONTRIBUTING.md?This PR adds a multi dict for query params.
It might be that this implementation will degrade performance a bit, so we need to test and see how it stacks vis-a-vis the previous one. I will run some benchmarks tomorrow to see.