Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save auth token #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Save auth token #27

wants to merge 2 commits into from

Conversation

nutella
Copy link

@nutella nutella commented Jun 25, 2024

I've modified Credentials.php to save auth token until expiration (typically 3600 seconds), so sequences of notifications will not require new token for each message submission.

Also added an example of notification with data payload.

@lkaybob
Copy link
Owner

lkaybob commented Jun 26, 2024

Saving individual access token inside package instance would cause security vulnerability. Access token should be managed outside of the library.

I guess it would be better to make Client class to accept access token when being created

@nutella
Copy link
Author

nutella commented Jun 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants