Merge pull request #93 from ll7/91-Remove-SimulationViewshow-method-f…

…rom-repository Refactor: remove simulation UI display calls from environment classes
ll7 · Dec 6, 2024 · 775f752 · 775f752
2 parents 9203fd6 + dc1ccd5
commit 775f752
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/robot_sf/gym_env/empty_robot_env.py b/robot_sf/gym_env/empty_robot_env.py
@@ -96,9 +96,6 @@ def __init__(
                 goal_radius=env_config.sim_config.goal_radius,
             )
 
-            # Display the simulation UI
-            self.sim_ui.show()
-
     def step(self, action):
         """
         Execute one time step within the environment.

diff --git a/robot_sf/gym_env/pedestrian_env.py b/robot_sf/gym_env/pedestrian_env.py
@@ -147,9 +147,6 @@ def __init__(
                 goal_radius=env_config.sim_config.goal_radius,
             )
 
-            # Display the simulation UI
-            self.sim_ui.show()
-
     def step(self, action):
         """
         Execute one time step within the environment.

diff --git a/robot_sf/gym_env/robot_env.py b/robot_sf/gym_env/robot_env.py
@@ -136,10 +136,6 @@ def __init__(
                 video_fps=video_fps,
             )
 
-            # Only show window if in debug mode
-            if debug:
-                self.sim_ui.show()
-
     def step(self, action):
         """
         Execute one time step within the environment.

diff --git a/robot_sf/render/playback_recording.py b/robot_sf/render/playback_recording.py
@@ -34,7 +34,6 @@ def visualize_states(states: List[VisualizableSimState], map_def: MapDefinition)
     on the recorded map defintion
     """
     sim_view = SimulationView(map_def=map_def, caption="RobotSF Recording")
-    sim_view.show()  # to activate key_events
     for state in states:
         sim_view.render(state)