Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slick scala3 support #378

Merged
merged 5 commits into from
Mar 23, 2024
Merged

slick scala3 support #378

merged 5 commits into from
Mar 23, 2024

Conversation

jtjeferreira
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 85.71%. Comparing base (46d051c) to head (fe5b834).
Report is 1 commits behind head on master.

Files Patch % Lines
...meratum/values/SlickValueEnumPlainSqlSupport.scala 58.33% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          63       63           
  Lines         511      511           
  Branches       34       34           
=======================================
  Hits          438      438           
  Misses         73       73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lloydmeta
lloydmeta approved these changes Nov 2, 2023
View reviewed changes
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just waiting for the weekend to merge + release.

jtjeferreira
jtjeferreira commented Nov 2, 2023
View reviewed changes
build.sbt Outdated
@@ -613,9 +613,10 @@ lazy val enumeratumSlick =
version := "1.7.5-SNAPSHOT",
crossScalaVersions := scalaVersionsAll,
libraryDependencies ++= Seq(
("com.typesafe.slick" %% "slick" % "3.4.1").cross(CrossVersion.for3Use2_13),
("com.typesafe.slick" %% "slick" % "3.5.0-M4"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this depends on a milestone version, so we can wait a bit

Copy link
Owner

@lloydmeta lloydmeta Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we're at M5 now; let's wait until we get to a stable release.

@jtjeferreira
Copy link
Contributor Author

@lloydmeta can you have a look?

lloydmeta
lloydmeta approved these changes Mar 16, 2024
View reviewed changes
Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not merging yet as I don't have bandwidth this week to release.

@lloydmeta lloydmeta merged commit 9ea252a into lloydmeta:master Mar 23, 2024
4 of 5 checks passed
@lloydmeta
Copy link
Owner

Thanks for this contribution and apologies for the long wait. Just released (pushed) 1.7.5 of enumeratum-slick to Maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloydmeta lloydmeta lloydmeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtjeferreira @codecov-commenter @lloydmeta @gbarrett-makeit