-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Play & Play JSON to 3.0 #381
Conversation
scalaVersion := scala_2_13Version, | ||
crossScalaVersions := Seq(scala_2_13Version, scala_3Version), | ||
libraryDependencies += ("org.playframework" %% "play" % "3.0.0") | ||
.exclude("org.scala-lang.modules", "*"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lloydmeta It's not clear to me why the exclude("org.scala-lang.modules", "*")
is present, I kept it in doubt but maybe it's not needed anymore?
I don't understand why 2.12 build fails but for sure it's related to my attempt to not build enumeratum-play for 2.12 anymore. Will investigate a bit more tomorrow. Unless you've got any idea. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 85.52% 85.71% +0.19%
==========================================
Files 65 63 -2
Lines 518 511 -7
Branches 31 34 +3
==========================================
- Hits 443 438 -5
+ Misses 75 73 -2 |
Wow.. this was tricky but I think I got it: from what I understand, the commands used in CI were not actually doing what you'd think. The This is the reason I had to make changes to CI:
I've done several commits but happy to move these unrelated changes to another PR first if you prefer to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just holding on merging until I get time to also release.
Thanks for this. Just pushed 1.8.0 of the Play integration libs to Maven central based on this. |
Great news :) |
Supersedes #380
com.typesafe.play
->org.playframework
)As discussed in #380, Play 2.x support is discontinued in favour of Play 3.x unless there is a strong demand for it.
Closes #382