allow value constructor param to be any constructor parameter, rather than only the first #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnhoekstra
force-pushed
the
allow-value-to-the-right
branch
2 times, most recently
from
6b54d77 to
a1cde16
Compare
martijnhoekstra
force-pushed
the
allow-value-to-the-right
branch
from
a1cde16 to
d3a872c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 63 63
Lines 511 511
Branches 34 34
=======================================
Hits 438 438
Misses 73 73 ☔ View full report in Codecov by Sentry. |
|
Thanks for this. I will definitely review this once I have some spare time 🙇♂️ |
lloydmeta
reviewed
Jun 30, 2024
lloydmeta
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify and correct finding the constructor param index for the value param.
As a follow-up, I want to double-check whether we need to require -Yretain-trees.
Some of the boyscouting here is a matter of taste, if it's not to yours, I'm happy to revert.