Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Scala native 0.4 to 0.5 #403

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Sep 10, 2024

Duplicates #402 but with a ScalaJS bump on top. @MateuszKubuszok said he's busy these days so I figured I could try moving the needle at least a tiny bit, and see what fails next.

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (10a084d) to head (fccff1b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          63       63           
  Lines         511      511           
  Branches       34       34           
=======================================
  Hits          438      438           
  Misses         73       73           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@lloydmeta lloydmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please mark as ready to review when you think it's ready.

I'll hold off on merging immediately anyway until I have time to also cut releases.

@kubukoz
Copy link
Contributor Author

kubukoz commented Sep 11, 2024

Just did a final Circe bump, I'm good with merging anytime :)

@kubukoz kubukoz marked this pull request as ready for review September 11, 2024 12:20
@lloydmeta lloydmeta added this to the 1.7.5 milestone Sep 15, 2024
@lloydmeta lloydmeta merged commit 657ad78 into lloydmeta:master Oct 4, 2024
3 checks passed
@kubukoz kubukoz deleted the scala-native0.5 branch October 4, 2024 12:55
@lloydmeta
Copy link
Owner

Thanks this has been released now.

@lloydmeta lloydmeta mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants