Detailed error on Enum reads in enumeratum-play-json #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR extends integration with play-json by providing possibility to print detailed error messages when deserialization of the enum value fails.
More details at #409
I implemented the logic and tests, but I am not sure what is the correct way to configure it. I did it via new trait
PlayDetailedErrorJsonEnum, but not sure whether it is the best option since a few traits with differentreadsstrategies already present (PlayInsensitiveJsonEnum,PlayLowercaseJsonEnum,PlayUppercaseJsonEnum) and it would look bad if I would add corresponding (PlayDetailedErrorInsensitiveJsonEnum,PlayDetailedErrorLowercaseJsonEnum,PlayDetailedErrorUppercaseJsonEnum).Will it make sense to configure it as system property? Like (
-Denumeratum.playjson.detailedError=true)? Or some another approach?