[PyCDE] Update build flow (#8008)

Fix the PyCDE build flow. Added nanobind and fixed dll install on Windows.
llvm · Dec 18, 2024 · 9468862 · 9468862
1 parent 00a5625
commit 9468862
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/frontends/PyCDE/pyproject.toml b/frontends/PyCDE/pyproject.toml
@@ -7,7 +7,8 @@ requires = [
 
   # MLIR build depends.
   "numpy",
-  "pybind11>=2.9",
+  "pybind11>=2.11,<=2.12",
+  "nanobind==2.4.0",
   "PyYAML",
 
   # PyCDE depends

diff --git a/frontends/PyCDE/setup.py b/frontends/PyCDE/setup.py
@@ -56,6 +56,8 @@ def run(self):
     if "BUILD_TYPE" in os.environ:
       cfg = os.environ["BUILD_TYPE"]
     cmake_args = [
+        "-Wno-dev",
+        "-GNinja",
         "-DCMAKE_INSTALL_PREFIX={}".format(os.path.abspath(cmake_install_dir)),
         "-DPython3_EXECUTABLE={}".format(sys.executable.replace("\\", "/")),
         "-DCMAKE_BUILD_TYPE={}".format(cfg),  # not used on MSVC, but no harm

diff --git a/frontends/PyCDE/src/CMakeLists.txt b/frontends/PyCDE/src/CMakeLists.txt
@@ -87,6 +87,13 @@ add_mlir_python_modules(PyCDE
     PyCDE_CIRCTPythonCAPI
 )
 
+install(TARGETS PyCDE_CIRCTPythonCAPI
+  DESTINATION python_packages/pycde/circt/_mlir_libs
+  RUNTIME_DEPENDENCIES
+    PRE_EXCLUDE_REGEXES ".*"
+    PRE_INCLUDE_REGEXES ".*zlib.*"
+  COMPONENT PyCDE
+)
 add_dependencies(PyCDE PyCDE_CIRCTPythonModules)
 add_dependencies(install-PyCDE install-PyCDE_CIRCTPythonModules)
 
@@ -103,15 +110,3 @@ install(FILES ${esiprims}
   DESTINATION python_packages/pycde
   COMPONENT PyCDE
 )
-
-install(IMPORTED_RUNTIME_ARTIFACTS PyCDE_CIRCTPythonCAPI
-  RUNTIME_DEPENDENCY_SET PyCDE_RUNTIME_DEPS
-  DESTINATION python_packages/pycde/circt/_mlir_libs
-  COMPONENT PyCDE
-)
-install(RUNTIME_DEPENDENCY_SET PyCDE_RUNTIME_DEPS
-  DESTINATION python_packages/pycde/circt/_mlir_libs
-  PRE_EXCLUDE_REGEXES .*
-  PRE_INCLUDE_REGEXES zlib1
-  COMPONENT PyCDE
-)