Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getDiscardableAttr to access discardable attributes #7761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use getDiscardableAttr to access discardable attributes #7761

wants to merge 1 commit into from

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Nov 1, 2024

No description provided.

@rwy7 rwy7 requested a review from youngar November 1, 2024 19:10
darthscsi
darthscsi approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This kind of trivial API usage refinement probably doesn't need a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthscsi darthscsi darthscsi approved these changes

@youngar youngar youngar approved these changes

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwy7 @youngar @darthscsi