Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MooreToCore] Add multibit DetectEventOp support #7943

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

AndreyVV-100
Copy link
Contributor

Hi! This PR add support for such code:

module Mod(input [1:0] a, output logic b);
always @(a)
    b <= a[0];
endmodule

I'm not sure about correctness of this code in common case due to #7925 but now (as I understand) only [width-1:0] arrays supported in Moore dialect.

Thank you in advance!

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks a lot for fixing this 🥳, really appreciated. Let me know if you'd like to merge this yourself once CI passes, or whether you'd like me to land this PR for you 🙂

@AndreyVV-100
Copy link
Contributor Author

Looks good to me! Thanks a lot for fixing this 🥳, really appreciated. Let me know if you'd like to merge this yourself once CI passes, or whether you'd like me to land this PR for you 🙂

I will be grateful if you land this PR.

@fabianschuiki fabianschuiki merged commit e9150ac into llvm:main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants