[CombToAIG] Add a lowering for Add/Sub #7968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` c ? a : b => (replicate(c) & a) | (~replicate(c) & b) ``` Add a LEC test for CombToAIG.
Some variadic operations (xor, add, mul etc) cannot directly lowered into varidic AIG operations. So this adds a pattern to pre-lower variadic operations.
uenoku
force-pushed
the
dev/hidetou/comb-to-aig-add
branch
from
9e0d671 to
bb259ea
Compare
uenoku
changed the title
This implements a pattern to lower AddOp to a naive ripple-carry adder. Pattern for sub is also added since we can easily compute subtraction from addition. This PR also adds a test-only option to `additional-legal-ops` to test complicated lowering pattern.
mikeurbach
approved these changes
Dec 12, 2024
uenoku
force-pushed
the
dev/hidetou/comb-to-aig-add
branch
from
bb259ea to
16d3da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a pattern to lower AddOp to a naive ripple-carry adder.
Pattern for sub is also added since we can easily compute subtraction from addition.
This PR also adds a test-only option to
additional-legal-opsto testcomplicated lowering pattern.