Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTG][Elaboration] Support sequences #7969

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maerhart
Copy link
Member

  • Simplify materializer to work on only one basic block
  • Remove unused addWorklist argument and use a class field instead
  • Because the way invocations are elaborated has changed, we don't need the worklist anymore within sequences or tests (we can just iterate over the operations since it's not a graph region), this is a big performance benefit in large tests/sequences.
  • Do a BFS over the sequence invocation hierarchy such that callees are only elaborated when all parents are elaborated (because only the sequence_closure operation should fix the randomization within a sequence, thus they create a clone before elaborating the referenced sequence)
  • Inline all sequences and remove them.

@maerhart maerhart added the RTG Involving the `rtg` dialect label Dec 11, 2024
@maerhart maerhart marked this pull request as draft December 11, 2024 13:57
@maerhart maerhart marked this pull request as ready for review December 12, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RTG Involving the `rtg` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant