[CD] Install nanobind when building wheels. #8005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently started supporting nanobind as a dependency in upstream MLIR. This is installed in our CI images, but not the Python wheel CI environment. This adds that dependency to the package used for the Python wheel build.
teqdruid
approved these changes
Dec 18, 2024
|
Oops forgot to post it, but there was a successful run here: https://github.com/llvm/circt/actions/runs/12387120557 Thanks for the review @teqdruid. |
|
I'm probably gonna have to make the same changes to PyCDE when I do the next release, so I'm paying attention. |
|
Ok sounds good. Sorry that I haven't also been updating PyCDE as I go, but there were other issues in my environment I would have needed to resolve before I could test PyCDE. I think at this point you can just grep for nanobind in this repo and circt/images to see where it's needed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently started supporting nanobind as a dependency in upstream MLIR. This is installed in our CI images, but not the Python wheel CI environment. This adds that dependency to the package used for the Python wheel build.