Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LowerToBMC] Topologically sort module body before inlining to BMC op #8007

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

TaoBi22
Copy link
Contributor

@TaoBi22 TaoBi22 commented Dec 18, 2024

Allows circt-bmc to support modules that contain non-dominance but can be topologically sorted. Doesn't cover every edge case (i.e. when modules get involved and there may be cycles), but I've run into needing this a few times so it's probably useful to have upstream.

@TaoBi22 TaoBi22 requested a review from maerhart December 18, 2024 16:53
Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/Tools/circt-bmc/LowerToBMC.cpp Outdated Show resolved Hide resolved
@TaoBi22 TaoBi22 merged commit 00a5625 into llvm:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants