Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyCDE] Update build flow #8008

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[PyCDE] Update build flow #8008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
676e7c9
[PyCDE] Adding nanobind to build requirements
teqdruid Dec 18, 2024
176931e
Changing way dependencies are installes
teqdruid Dec 18, 2024
ca541aa
remove commented out lines
teqdruid Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontends/PyCDE/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ requires = [

# MLIR build depends.
"numpy",
"pybind11>=2.9",
"pybind11>=2.11,<=2.12",
"nanobind==2.4.0",
"PyYAML",

# PyCDE depends
Expand Down
2 changes: 2 additions & 0 deletions frontends/PyCDE/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def run(self):
if "BUILD_TYPE" in os.environ:
cfg = os.environ["BUILD_TYPE"]
cmake_args = [
"-Wno-dev",
"-GNinja",
"-DCMAKE_INSTALL_PREFIX={}".format(os.path.abspath(cmake_install_dir)),
"-DPython3_EXECUTABLE={}".format(sys.executable.replace("\\", "/")),
"-DCMAKE_BUILD_TYPE={}".format(cfg), # not used on MSVC, but no harm
Expand Down
19 changes: 7 additions & 12 deletions frontends/PyCDE/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,13 @@ add_mlir_python_modules(PyCDE
PyCDE_CIRCTPythonCAPI
)

install(TARGETS PyCDE_CIRCTPythonCAPI
DESTINATION python_packages/pycde/circt/_mlir_libs
RUNTIME_DEPENDENCIES
PRE_EXCLUDE_REGEXES ".*"
PRE_INCLUDE_REGEXES ".*zlib.*"
COMPONENT PyCDE
)
add_dependencies(PyCDE PyCDE_CIRCTPythonModules)
add_dependencies(install-PyCDE install-PyCDE_CIRCTPythonModules)

Expand All @@ -103,15 +110,3 @@ install(FILES ${esiprims}
DESTINATION python_packages/pycde
COMPONENT PyCDE
)

install(IMPORTED_RUNTIME_ARTIFACTS PyCDE_CIRCTPythonCAPI
RUNTIME_DEPENDENCY_SET PyCDE_RUNTIME_DEPS
DESTINATION python_packages/pycde/circt/_mlir_libs
COMPONENT PyCDE
)
install(RUNTIME_DEPENDENCY_SET PyCDE_RUNTIME_DEPS
DESTINATION python_packages/pycde/circt/_mlir_libs
PRE_EXCLUDE_REGEXES .*
PRE_INCLUDE_REGEXES zlib1
COMPONENT PyCDE
)
Loading