[lib/conversion] Create seed only if needed in `convert-torch-convers… #3926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion-to-mlprogram` pass This PR changes `convert-torch-conversion-to-mlprogram` pass implementation by moving seed generation inside `ConvertGetNextSeedOp` pattern. Previously, global seed was being created by this pass, even when its only consumer `torch_c.get_next_seed` op is not present in the IR. This pass is part of Torch->Linalg conversion pipeline. Always creating global seed created an issue for the case when downstream compiler doesn't expect/support `ml_program` dialect in linalg on tensor IR format. However, when starting torch IR has `torch_c.get_next_seed` op, `ml_program` will still be present and will need to be handled by downstream compilers.
|
@ramiro050 @stellaraccident can you please take a look? |
|
I'm on vacation and will review substantial changes when I'm back. If you can find another reviewer who knows these parts, that is fine too |
|
@vivekkhandelwal1 can you please review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion-to-mlprogram` pass
This PR changes
convert-torch-conversion-to-mlprogrampass implementation by moving seed generation insideConvertGetNextSeedOppattern.Previously, global seed was being created by this pass, even when its only consumer
torch_c.get_next_seedop is not present in the IR. This pass is part of Torch->Linalg conversion pipeline. Always creating global seed created an issue for the case when downstream compiler doesn't expect/supportml_programdialect in linalg on tensor IR format. However, when starting torch IR hastorch_c.get_next_seedop,ml_programwill still be present and will need to be handled by downstream compilers.