Modify ramp colors correspond to days in a week, in a rainbow order #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of reposense#2216
Explanation
The color in a ramp indicates the day in which a commit is done, in a 5-day cycle. Currently, the colors do not have much meaning beyond telling the user that the commits are done within a day. Furthermore, one of the colors used, pink, was too similar to red, the color reserved for delete commits. Thus, this PR is made to address these issues.
Each color now corresponds to each day in a week (i.e. the 5-day cycle is replaced by 7-day cycle). To make the colors easy to remember, they follow the rainbow colors, but with red being replaced with brown (as red is reserved for delete commits), and yellow being replaced with lime (to increase contrast against the bright background). Monday (first day in a working week) corresponds to the first color. These colors are all distinct from red, hence allowing the user to easily distinguish between delete commits and other commits.
Screenshot