Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(env-check): remove dependency of system package manager from node env checker #3406

Merged
merged 2 commits into from
Dec 25, 2024
Merged

feat(env-check): remove dependency of system package manager from node env checker #3406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66a361b
feat(env-check): check package installation without system package ma…
COLDTURNIP Dec 24, 2024
8bc8d98
feat(env-check): remove env check condition when host OS is unsupported
COLDTURNIP Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 45 additions & 48 deletions controller/monitor/environment_check_monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,8 @@ func (m *EnvironmentCheckMonitor) environmentCheck(kubeNode *corev1.Node) *Colle

func (m *EnvironmentCheckMonitor) syncPackagesInstalled(kubeNode *corev1.Node, namespaces []lhtypes.Namespace, collectedData *CollectedEnvironmentCheckInfo) {
osImage := strings.ToLower(kubeNode.Status.NodeInfo.OSImage)
queryPackagesCmd := ""
options := []string{}
packages := []string{}
pipeFlag := false

packageProbeExecutables := make(map[string]string)

switch {
case strings.Contains(osImage, "talos"):
Expand All @@ -190,10 +188,10 @@ func (m *EnvironmentCheckMonitor) syncPackagesInstalled(kubeNode *corev1.Node, n
case strings.Contains(osImage, "ubuntu"):
fallthrough
case strings.Contains(osImage, "debian"):
queryPackagesCmd = "dpkg"
options = append(options, "-l")
packages = append(packages, "nfs-common", "open-iscsi", "cryptsetup", "dmsetup")
pipeFlag = true
packageProbeExecutables["nfs-common"] = "mount.nfs"
COLDTURNIP marked this conversation as resolved.
Show resolved Hide resolved
packageProbeExecutables["open-iscsi"] = "iscsiadm"
packageProbeExecutables["cryptsetup"] = "cryptsetup"
packageProbeExecutables["dmsetup"] = "dmsetup"
case strings.Contains(osImage, "centos"):
fallthrough
case strings.Contains(osImage, "fedora"):
Expand All @@ -203,66 +201,47 @@ func (m *EnvironmentCheckMonitor) syncPackagesInstalled(kubeNode *corev1.Node, n
case strings.Contains(osImage, "rocky"):
fallthrough
case strings.Contains(osImage, "ol"):
queryPackagesCmd = "rpm"
options = append(options, "-q")
packages = append(packages, "nfs-utils", "iscsi-initiator-utils", "cryptsetup", "device-mapper")
packageProbeExecutables["nfs-utils"] = "mount.nfs"
packageProbeExecutables["iscsi-initiator-utils"] = "iscsiadm"
packageProbeExecutables["cryptsetup"] = "cryptsetup"
packageProbeExecutables["device-mapper"] = "dmsetup"
case strings.Contains(osImage, "suse"):
queryPackagesCmd = "rpm"
options = append(options, "-q")
packages = append(packages, "nfs-client", "open-iscsi", "cryptsetup", "device-mapper")
packageProbeExecutables["nfs-client"] = "mount.nfs"
packageProbeExecutables["open-iscsi"] = "iscsiadm"
packageProbeExecutables["cryptsetup"] = "cryptsetup"
packageProbeExecutables["device-mapper"] = "dmsetup"
case strings.Contains(osImage, "arch"):
queryPackagesCmd = "pacman"
options = append(options, "-Q")
packages = append(packages, "nfs-utils", "open-iscsi", "cryptsetup", "device-mapper")
packageProbeExecutables["nfs-utils"] = "mount.nfs"
packageProbeExecutables["open-iscsi"] = "iscsiadm"
packageProbeExecutables["cryptsetup"] = "cryptsetup"
packageProbeExecutables["device-mapper"] = "dmsetup"
case strings.Contains(osImage, "gentoo"):
queryPackagesCmd = "qlist"
options = append(options, "-I")
packages = append(packages, "net-fs/nfs-utils", "sys-block/open-iscsi", "sys-fs/cryptsetup", "sys-fs/lvm2")
packageProbeExecutables["net-fs/nfs-utils"] = "mount.nfs"
packageProbeExecutables["sys-block/open-iscsi"] = "iscsiadm"
packageProbeExecutables["sys-fs/cryptsetup"] = "cryptsetup"
packageProbeExecutables["sys-fs/lvm2"] = "dmsetup"
COLDTURNIP marked this conversation as resolved.
Show resolved Hide resolved
default:
collectedData.conditions = types.SetCondition(collectedData.conditions, longhorn.NodeConditionTypeRequiredPackages, longhorn.ConditionStatusFalse,
string(longhorn.NodeConditionReasonUnknownOS),
fmt.Sprintf("Unable to verify the required packages because the OS image '%v' is unknown to the Longhorn system. Please ensure the required packages are installed.", osImage))
// unsupported host platform, skip environment check condition
return
}

nsexec, err := lhns.NewNamespaceExecutor(lhtypes.ProcessNone, lhtypes.HostProcDirectory, namespaces)
installedPackages, notInstalledPackages, err := m.checkPackageInstalled(packageProbeExecutables, namespaces)
if err != nil {
collectedData.conditions = types.SetCondition(collectedData.conditions, longhorn.NodeConditionTypeRequiredPackages, longhorn.ConditionStatusFalse,
string(longhorn.NodeConditionReasonNamespaceExecutorErr),
fmt.Sprintf("Failed to get namespace executor: %v", err.Error()))
return
}

notFoundPkgs := []string{}
for _, pkg := range packages {
args := options
if !pipeFlag {
args = append(args, pkg)
}
queryResult, err := nsexec.Execute(nil, queryPackagesCmd, args, lhtypes.ExecuteDefaultTimeout)
if err != nil {
m.logger.WithError(err).Debugf("Package %v is not found", pkg)
notFoundPkgs = append(notFoundPkgs, pkg)
continue
}
if pipeFlag {
if _, err := lhexec.NewExecutor().ExecuteWithStdinPipe("grep", []string{"-w", pkg}, queryResult, lhtypes.ExecuteDefaultTimeout); err != nil {
m.logger.WithError(err).Debugf("Package %v is not found", pkg)
notFoundPkgs = append(notFoundPkgs, pkg)
continue
}
}
}

if len(notFoundPkgs) > 0 {
if len(notInstalledPackages) > 0 {
collectedData.conditions = types.SetCondition(collectedData.conditions, longhorn.NodeConditionTypeRequiredPackages, longhorn.ConditionStatusFalse,
string(longhorn.NodeConditionReasonPackagesNotInstalled),
fmt.Sprintf("Missing packages: %v", notFoundPkgs))
fmt.Sprintf("Missing packages: %v", notInstalledPackages))
return
}

collectedData.conditions = types.SetCondition(collectedData.conditions, longhorn.NodeConditionTypeRequiredPackages, longhorn.ConditionStatusTrue, "",
fmt.Sprintf("All required packages %v are installed", packages))
fmt.Sprintf("All required packages %v are installed", installedPackages))
}

func (m *EnvironmentCheckMonitor) syncPackagesInstalledTalosLinux(namespaces []lhtypes.Namespace, collectedData *CollectedEnvironmentCheckInfo) {
Expand Down Expand Up @@ -360,6 +339,24 @@ func (m *EnvironmentCheckMonitor) syncMultipathd(namespaces []lhtypes.Namespace,
collectedData.conditions = types.SetCondition(collectedData.conditions, longhorn.NodeConditionTypeMultipathd, longhorn.ConditionStatusTrue, "", "")
}

func (m *EnvironmentCheckMonitor) checkPackageInstalled(packageProbeExecutables map[string]string, namespaces []lhtypes.Namespace) (installed, notInstalled []string, err error) {
nsexec, err := lhns.NewNamespaceExecutor(lhtypes.ProcessNone, lhtypes.HostProcDirectory, namespaces)
if err != nil {
return nil, nil, err
}

for pkg, executable := range packageProbeExecutables {
shellCmd := fmt.Sprintf("command -v %s", executable)
if _, err := nsexec.Execute(nil, "sh", []string{"-c", shellCmd}, lhtypes.ExecuteDefaultTimeout); err != nil {
m.logger.WithError(err).Debugf("Package %v is not found", pkg)
notInstalled = append(notInstalled, pkg)
} else {
installed = append(installed, pkg)
}
}
return installed, notInstalled, nil
}

func (m *EnvironmentCheckMonitor) checkHugePages(kubeNode *corev1.Node, collectedData *CollectedEnvironmentCheckInfo) {
hugePageLimitInMiB, err := m.ds.GetSettingAsInt(types.SettingNameV2DataEngineHugepageLimit)
if err != nil {
Expand Down
Loading