-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(env-check): remove dependency of system package manager from node env checker (backport #3406) #3409
base: v1.7.x
Are you sure you want to change the base?
Conversation
Cherry-pick of 1d6fc2c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@COLDTURNIP Need to resolve the conflicts. |
e9e4557
to
f1df1d4
Compare
…nager longhorn/longhorn-10019 Signed-off-by: Raphanus Lo <[email protected]> (cherry picked from commit 1d6fc2c) # Conflicts: # controller/monitor/environment_check_monitor.go
longhorn/longhorn-10019 Signed-off-by: Raphanus Lo <[email protected]> (cherry picked from commit a27e0ba)
f1df1d4
to
61f5fbe
Compare
Which issue(s) this PR fixes:
Issue longhorn/longhorn#10019
What this PR does / why we need it:
Instead of reading the system package database, check the executables needed by the system, to eliminate the system management tool chain issue.
Special notes for your reviewer:
Additional documentation or context
This is an automatic backport of pull request #3406 done by [Mergify](https://mergify.com).