This repository has been archived by the owner on Aug 14, 2023. It is now read-only.
basic: update the Arch tuple for LoongArch #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
哦 commit message 那个 tuple 要用复数，tuples |
cnmushiba
approved these changes
Mar 11, 2022
sdlaqz
approved these changes
Mar 23, 2022
yetist
commented
Mar 24, 2022
src/basic/architecture.h
Outdated
| #elif defined(__loongarch64) | ||
| # pragma message "Please update the Arch tuple of loongarch64 after psABI is stable" | ||
| #elif defined(__loongarch__) | ||
| # if defined(__loongarch32) |
There was a problem hiding this comment.
查了 gcc 代码，发现这个是写错了，没有定义宏 __loongarch32： https://github.com/loongson/gcc/blob/loongarch-12/gcc/config/loongarch/loongarch-c.cc
There was a problem hiding this comment.
这怎么说呢，这种内置宏的设计，应该符合人的直觉和常识才对。
现在有的前后都有双下划线，有的只有前面有双下划线，后面没有，如：__loongarch__ 和 __loongarch64。
还有，定义了 __loongarch64，却没有定义 __loongarch32。
There was a problem hiding this comment.
发起了一个讨论: loongson/LoongArch-Documentation#46
yetist
force-pushed
the
dev-loongarch
branch
2 times, most recently
from
a1c6104 to
6078ad3
Compare
|
补丁不完整，导致测试没通过：https://github.com/systemd/systemd/runs/5686676827?check_suite_focus=true#step:4:5111 由于 32 位的 loongarch 不知道 |
|
上游 PR 已合并：systemd#22864 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
按最新规范修改，请测试评审，谢谢。