Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added container type argument for love.data.hash #2018

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

EngineerSmith
Copy link
Contributor

Changed love.data.hash to accept a container type as an argument. This will be a breaking change!

I made the issue #2015, and decided to implement it. If you believe this change is too breaking, or unnecessary, feel free to reject it.

This PR also updates the tests, and adds the change to the changes.txt

local ld = love.data
local data = ld.newByteData("helloworld")

-- old
local hashed = ld.hash("sha512", data)
-- above replaced by
local hashed = ld.hash("string", "sha512", data)

-- new functionality
local hashed = ld.hash("data", "sha512", data)

Copy link
Member

@slime73 slime73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 12.0-development branch has been merged into main now, you'll need to change the base branch of this PR to main as well.

@EngineerSmith EngineerSmith changed the base branch from 12.0-development to main February 13, 2024 01:18
Copy link
Member

@slime73 slime73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@slime73 slime73 merged commit 483237e into love2d:main Feb 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants