Made love.data.newDataView size arg optional #2088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed that I had to keep calculating the size lua side when making a new dataview. So, this change makes the 3rd arg [size], optional and is calculated as
love.data.newByteData
calculates the default size when callinglove.data.newByteData(someData)
this lineI made this change on github directly; and so I haven't tested the change. I'll add a comment once I've tested the build to ensure it works as expected.
Example usage: