-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pmp] Use top-level straps for PMP reset values #2147
Conversation
392f556
to
3048b86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a sensible change to me.
@GregAC can you see any problem with this? If not, I'm happy to take it.
I had intentionally avoid doing this with parameters when I first wrote it to avoid adding yet more parameters to Ibex, though given we've already got loads perhaps it doesn't matter. Ultimately this is probably what we have to do but I'll have a think about alternative methods. |
@Razer6 we intend to take this, I just need to do a couple of checks to ensure there's no issues for non PMP configs or breakages in other things we don't check in CI I hope to get this done over the next couple of days. |
@GregAC No hurry on that one. We have changed that in our environment and are not dependent on vendoring in a new version of ibex at the moment. |
3048b86
to
1aeecdb
Compare
@GregAC @rswarbrick Could you take another look? |
@Razer6 yes will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me thanks @Razer6 just a couple of small nits to address.
1aeecdb
to
ad0f4cb
Compare
By using top-level straps for the PMP reset configuration its easier to implement different reset configurations if there are multiple Ibex cores in the system. Signed-off-by: Robert Schilling <[email protected]>
ad0f4cb
to
40d2f13
Compare
Thanks @GregAC for the review. I just updated the changes for the nits. |
Thanks @Razer6 |
By using top-level straps for the PMP reset configuration its easier to implement different reset configurations if there are multiple Ibex cores in the system.