Move quality checks to private package #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The targets in this package are only for local testing and do not need to be exposed to depending Bazel modules. This prevents errors when querying the whole module when the `aspect_rules_lint` dependency won't be available. Signed-off-by: James Wainwright <[email protected]>
This repository internally still requires `WORKSPACE` for loading Ruff from `aspect_rules_lint`. Bazel 8 has now been released which doesn't support `WORKSPACE`. Signed-off-by: James Wainwright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The targets in this package are only for local testing and do not need to be exposed to depending Bazel modules. This prevents errors when querying the whole module when the
aspect_rules_lintdependency won't be available.