Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[top_englishbreakfast] Add second UART #24611

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

vogelpi
Copy link
Contributor

@vogelpi vogelpi commented Sep 20, 2024

For penetration testing, we've been using a second UART on the CW310 and the silicon platform such that the host can directly communicate with the target using the uJSON protocol instead of looping this communication through the simpleserial channel with the scope (available on Husky only anyways).

This commit now adds a second UART to the English Breakfast top level such that we can re-align the capture setups again. Ultimately, this will allow removing the simpleserial-based communication which will quite notably simplify code maintenance in the future.

For reference, see also lowRISC/ot-sca#235.

@vogelpi vogelpi requested review from msfschaffner and a team as code owners September 20, 2024 11:17
@vogelpi vogelpi requested review from alees24, pamaury, nasahlpa and andrea-caforio and removed request for a team, msfschaffner and alees24 September 20, 2024 11:17
@vogelpi
Copy link
Contributor Author

vogelpi commented Sep 20, 2024

@nasahlpa , @andrea-caforio , I've successfully tested this using simpleserial on the FPGA connected to our shared workstation. To get the uJSON communication working in ot-sca CI, we'll also need to connect an additional FTDI to the IO5 and IO6 pins of the JP3 header. This is because on the CW305, the integrated of UARTs/USARTs of the SAM3U microcontroller are unfortunately not connected to the FPGA.

For penetration testing, we've been using a second UART on the CW310 and
the silicon platform such that the host can directly communicate with
the target using the uJSON protocol instead of looping this
communication through the simpleserial channel with the scope
(available on Husky only anyways).

This commit now adds a second UART to the English Breakfast top level
such that we can re-align the capture setups again. Ultimately, this
will allow removing the simpleserial-based communication which will
quite notably simplify code maintenance in the future.

For reference, see also lowRISC/ot-sca#235.

Signed-off-by: Pirmin Vogel <[email protected]>
Copy link
Contributor

@pamaury pamaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The software side looks good to me

Copy link
Member

@nasahlpa nasahlpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

@vogelpi
Copy link
Contributor Author

vogelpi commented Sep 20, 2024

Thanks for your reviews guys!

@vogelpi vogelpi merged commit db48ef6 into lowRISC:master Sep 20, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants