[otbn/tvla] add option to configure the used samples per trace #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-temp
requested review from
abdullahvarici,
alphan,
andreaskurth,
vogelpi and
vrozic
as code owners
m-temp
force-pushed
the
samples-per-trace
branch
from
4a56bdd to
73799ba
Compare
22 tasks
vrozic
reviewed
Mar 1, 2023
vrozic
reviewed
Mar 1, 2023
|
Thanks @m-temp for adding this feature and for linking the issue. I think that with the suggested changes this feature can work for all modes, so maybe it's worth doing it now. |
vrozic
reviewed
Mar 1, 2023
This option is currently only tested for otbn traces. Signed-off-by: Michael Tempelmeier <[email protected]>
m-temp
force-pushed
the
samples-per-trace
branch
from
73799ba to
ae595ee
Compare
vrozic
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is currently only available for traces with
dtype=np.uint16Do we still support traces with
dtype=np.double?It is only tested for otbn and rises a runtime error if used for other modes.
See also: #72