-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sca, kmac] Add new capture script for KMAC #229
Conversation
29652b1
to
7708152
Compare
Thanks @m-temp, I will have a closer look tomorrow. Regarding the samples vs. cycles. You either can specify whether you want to configure the Husky scope in samples or cycles. If both are provided, the samples are taken. So if you know how many cycles a KMAC run takes, you probably want to configure the num_cycles parameter and remove the num_samples. |
Thanks for changing the configuration file! Capture trace looks IMHO good. Could you please try to run TVLA? Do you think capturing KMAC traces should be added to CI? |
Thanks @m-temp . Great work I've tested all three capture types locally with my setup and they all work. TVLA works well with one caveat. At the moment TVLA figures of general test results contain meta-data that are read from the project file. This reports an error when we use the new data-base format. After slightly modifying the The results look as expected. |
I see that for AES captures, we're using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my view this is ready to merge, modulo two small comments.
We should open an issue to remember to add this capture to CI later on.
This commit adds the new capture script to reflect the recent changes in the repository. Signed-off-by: Michael Tempelmeier <[email protected]>
done |
This PR addresses #217
As this was a major rework, it would be good if s.o. could test if the TVLA still works.
There are three open points: