[tvla] Fix plotting issues with new database and metadata format #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wettermo
requested review from
andreaskurth,
nasahlpa,
vogelpi and
vrozic
as code owners
wettermo
requested review from
m-temp,
nasahlpa and
vrozic
and removed request for
andreaskurth,
nasahlpa,
vogelpi and
vrozic
wettermo
force-pushed
the
tvla-fix-plot-restructure
branch
2 times, most recently
from
48650e4 to
6d6c3ad
Compare
22 tasks
This commit fixes incompatibility of tvla plotting with the new database and metadata format. For this, additional metadata is stored in aes and otbn capture. Also, a new wrapper function for plotting is added to the tvla script. Finally, aes and otbn config files are adjusted. Further, this commit adds code to also include metadata in plots of aes specific test. Signed-off-by: Moritz Wettermann <[email protected]>
Signed-off-by: Moritz Wettermann <[email protected]>
wettermo
force-pushed
the
tvla-fix-plot-restructure
branch
from
6d6c3ad to
f653abd
Compare
nasahlpa
approved these changes
Jan 8, 2024
|
I'm merging this PR, even though CI fails, because CI failure is unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes incompatibility of tvla plotting with the new database and metadata format.
For this, additional metadata is stored in aes, otbn, kmac and sha3 capture. Also, a new wrapper function for plotting is added to the tvla script. Finally, aes, otbn, kmac and sha3 config files are adjusted.
Further, this PR adds code to also include metadata in plots of aes specific tests.
Through this PR two tasks in #72 are addressed: