[capture] Add trigger source command #303
Conversation
nasahlpa
force-pushed
the
swtrigger
branch
2 times, most recently
from
f2e5e40 to
9c01397
Compare
nasahlpa
requested review from
andreaskurth,
vogelpi and
vrozic
as code owners
| # TODO: without the delay, the device uJSON command handler program | ||
| # does not recognize the commands. Tracked in issue #256. |
There was a problem hiding this comment.
nit: We usually use this format for TODO. Makes it easier to search the repository.
TODO(#256): Without the delay, the device uJSON command handler program does not recognize the commands.
There was a problem hiding this comment.
Good point raised by @vrozic. Please make sure to align the format before merging.
There was a problem hiding this comment.
Hm I followed the recommendation of the OpenTitan C style guide regarding comments. There seems not to be a recommendation for Python though.
But I am following @vrozic advise and change it to TODO(#256) for now and I created an issue (#308) that we can streamline this later on.
| # TODO: without the delay, the device uJSON command handler program | ||
| # does not recognize the commands. Tracked in issue #256. |
There was a problem hiding this comment.
Good point raised by @vrozic. Please make sure to align the format before merging.
| # does not recognize the commands. Tracked in issue #256. | ||
| time.sleep(0.01) | ||
| self.target.write(json.dumps("TriggerSca").encode("ascii")) | ||
| # DisableMasking command. |
nasahlpa
force-pushed
the
swtrigger
branch
7 times, most recently
from
80ce457 to
fcf0bf7
Compare
This PR adds the SCA trigger source command to the capture scripts. Needed to start penetration tests at ASIC as there is no HW trigger available. Signed-off-by: Pascal Nasahl <[email protected]>
This commit updates the binary to the latest uJSON SCA code that is located in lowRISC/opentitan#21224. Signed-off-by: Pascal Nasahl <[email protected]>
This PR adds the SCA trigger source command to the capture scripts. Needed to start penetration tests at ASIC as there is no HW trigger available.