-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Greeting Feature #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR!
Added a few smaller remarks and one larger suggestion for a redesign of a prompt management solution. If you prefer to solve it in a separate PR, just stack it on top of this one.
return null; | ||
} | ||
|
||
Message savedSystemMessage = createSystemMessage(currentSession, systemResponse); | ||
return MessageDTO.fromMessage(savedSystemMessage); | ||
} | ||
|
||
private String generateResponse(Long sessionId, String messageContent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am probably missing something here since this isn't new code - but the messageContent
is currently not passed to the IS, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GODrums the idea is that the latest message is first saved to the session and then passed as part of the message history to the intelligence-service
, we do not send it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense.
Since messageContent
is not used in generateResponse
directly, we can just omit it as parameter then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GODrums you are totally right - thanks for noticing! :)
...pplication-server/src/main/java/de/tum/in/www1/hephaestus/mentor/message/MessageService.java
Outdated
Show resolved
Hide resolved
...pplication-server/src/main/java/de/tum/in/www1/hephaestus/mentor/session/SessionService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for implementing the suggestions!
Tested it locally.
I'll merge and deploy it together with the Docs-PR later today.
Motivation
We aim for the AI mentor to directly engage with the student at the beginning of each session (aka send the first message) to clarify its purpose and enhance the flow of interaction.
Description
Testing Instructions
Screenshots (if applicable)
Checklist
General
Client (if applicable)
Server (if applicable)