Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add barcode/scan icons/optimise/improve metadata #1354

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Add barcode/scan icons/optimise/improve metadata #1354

merged 9 commits into from
Oct 3, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented Jun 10, 2023 •
edited
Loading

Loosely related to #1344.

@github-actions
Copy link

github-actions bot commented Jun 10, 2023 •
edited
Loading

Added or changed icons

icons/barcode.svg icons/fullscreen.svg icons/scan-barcode.svg icons/scan-eye.svg icons/scan-line.svg icons/scan-search.svg icons/scan-text.svg

Preview cohesion icons/kanban-square-dashed.svg icons/m-square.svg icons/scissors-square-dashed-bottom.svg icons/arrow-up-right-square.svg icons/message-square.svg icons/kanban-square.svg icons/function-square.svg
icons/barcode.svg icons/fullscreen.svg icons/scan-barcode.svg icons/scan-eye.svg icons/scan-line.svg icons/scan-search.svg icons/scan-text.svg
icons/bluetooth-connected.svg icons/paint-bucket.svg icons/bluetooth-off.svg icons/trophy.svg icons/book-open-check.svg icons/user-plus.svg icons/file-json-2.svg
Preview stroke widths icons/barcode.svg icons/fullscreen.svg icons/scan-barcode.svg icons/scan-eye.svg icons/scan-line.svg icons/scan-search.svg icons/scan-text.svg
icons/barcode.svg icons/fullscreen.svg icons/scan-barcode.svg icons/scan-eye.svg icons/scan-line.svg icons/scan-search.svg icons/scan-text.svg
icons/barcode.svg icons/fullscreen.svg icons/scan-barcode.svg icons/scan-eye.svg icons/scan-line.svg icons/scan-search.svg icons/scan-text.svg
DPI Preview (24px) icons/barcode.svg icons/fullscreen.svg icons/scan-barcode.svg icons/scan-eye.svg icons/scan-line.svg icons/scan-search.svg icons/scan-text.svg
Icon X-rays icons/barcode.svg icons/fullscreen.svg icons/scan-barcode.svg icons/scan-eye.svg icons/scan-line.svg icons/scan-search.svg icons/scan-text.svg

jguddas
jguddas approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@jguddas jguddas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a violation 😞, but it looks sooooooo good.

@danielbayley danielbayley changed the title Add barcode icon Add barcode/scan icons/optimise/improve metadata Jun 13, 2023
@github-actions github-actions bot added 🌍 site Has to do something with the Lucide website 🎨 icon About new icons 🫧 metadata Improved metadata labels Jun 23, 2023
@github-actions github-actions bot added the Stale label Jul 25, 2023
@danielbayley
Copy link
Member Author

It's a violation 😞, but it looks sooooooo good.

Oh no! 😭 Is it really? How?

@karsa-mistmere
Copy link
Member

It's a violation 😞, but it looks sooooooo good.

Oh no! 😭 Is it really? How?

Yeah, I'm afraid the 1px wide rectangles aren't something we have in any other icons, and they don't scale well:
image

@github-actions github-actions bot removed Stale 🌍 site Has to do something with the Lucide website labels Jul 26, 2023
@danielbayley danielbayley requested a review from jguddas July 26, 2023 17:53
@danielbayley
Copy link
Member Author

Such a shame! Fixed now anyway… @karsa-mistmere @jguddas

@jguddas
Copy link
Member

jguddas commented Aug 12, 2023

not sure scan is the right word

@danielbayley
Copy link
Member Author

not sure scan is the right word

@jguddas It’s the existing naming… What else should it be?

@github-actions github-actions bot added the Stale label Sep 12, 2023
ericfennis
ericfennis approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicee ones!!

@ericfennis ericfennis removed the Stale label Oct 3, 2023
@lucide-icons lucide-icons deleted a comment from github-actions bot Oct 3, 2023
@lucide-icons lucide-icons deleted a comment from github-actions bot Oct 3, 2023
@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lucide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:50am

@ericfennis ericfennis merged commit fd9ab8f into lucide-icons:main Oct 3, 2023
4 checks passed
@danielbayley danielbayley deleted the barcode branch October 4, 2023 02:43
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@danielbayley @ericfennis
Add barcode/scan icons/optimise/improve metadata (lucide-icons#1354)
ab12955 
* Add `barcode` icon

* Add `scan-barcode` icon

* Add `scan-text` icon

* Improve `scan` icons metadata

* Add `scan-eye` icon

* Add `scan-search` icon

* Optimise `scan-line` icon

* Add `fullscreen` icon

---------

Co-authored-by: Eric Fennis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jguddas jguddas jguddas approved these changes

@ericfennis ericfennis ericfennis approved these changes

Assignees
No one assigned
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbayley @karsa-mistmere @jguddas @ericfennis