Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added umbrella-off icon #1568

Merged

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Sep 18, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Icon use case

Unsecure / unprotected / without antivirus.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons: umbrella
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Added or changed icons

icons/umbrella-off.svg

Preview cohesion icons/pen-square.svg
icons/umbrella-off.svg
icons/battery-medium.svg
Preview stroke widths icons/umbrella-off.svg
icons/umbrella-off.svg
icons/umbrella-off.svg
DPI Preview (24px) icons/umbrella-off.svg
Icon X-rays icons/umbrella-off.svg

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm find the usecase a bit weak. For antivirus I will think more about the shield icon.

@karsa-mistmere
Copy link
Member

I like this one in general, although I share Eric's scepticism about use cases.

Some further use cases I could come up with, all signifying the concept of "uncovered" either literally and figuratively, e.g.:

  • to signify that a venue is outdoors and has no protection from the elements
  • in insurance services, that a particular service or item is not covered by the policy
  • in finance apps that investment or financial decision is risky and not protected

None of these feel super strong, but I'm okay with merging this if you think these use cases warrant it a spot. :)

icons/umbrella-off.json Outdated Show resolved Hide resolved
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karsa-mistmere Good points and use cases. I agree with you!
Good to go

@karsa-mistmere karsa-mistmere merged commit c05c7e3 into lucide-icons:main Oct 12, 2023
3 checks passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
* feat: added umbrella-off icon

* Update umbrella-off.svg

* Update umbrella-off.svg

* Update umbrella-off.svg

* Update icons/umbrella-off.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants