Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): added globe-lock icon #1587

Merged
merged 8 commits into from
Feb 26, 2024
Merged

feat(icons): added globe-lock icon #1587

merged 8 commits into from
Feb 26, 2024

Conversation

karsa-mistmere
Copy link
Member

What is the purpose of this pull request?

  • New Icon

Description

Added a globe-lock icon

Icon use case

  • VPN
  • Secure connection
  • Internet security
  • Password/digital identity protection
  • Privacy mode
  • Data encryption

Alternative icon designs

No viable alternates were made.

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • I've based them on the following Lucide icons: globe-2 and file-lock

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Added or changed icons

icons/earth-lock.svgicons/globe-lock.svgicons/earth.svg

Preview cohesion icons/kanban-square-dashed.svgicons/arrow-down-square.svgicons/square-radical.svg
icons/earth-lock.svgicons/globe-lock.svgicons/earth.svg
icons/flame.svgicons/computer.svgicons/timer-reset.svg
Preview stroke widths icons/earth-lock.svgicons/globe-lock.svgicons/earth.svg
icons/earth-lock.svgicons/globe-lock.svgicons/earth.svg
icons/earth-lock.svgicons/globe-lock.svgicons/earth.svg
DPI Preview (24px) icons/earth-lock.svgicons/globe-lock.svgicons/earth.svg
Icon X-rays icons/earth-lock.svgicons/globe-lock.svgicons/earth.svg

@jguddas
Copy link
Member

jguddas commented Oct 6, 2023

Why not have the lock in the bottom right corner?

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Oct 6, 2023 •
edited
Loading

Why not have the lock in the bottom right corner?

Because I tried that and found that it looked pretty damn awful compared to this. :D
(Hence the "no viable alternatives").

image

@jguddas
Copy link
Member

jguddas commented Oct 6, 2023

Why not have the lock in the bottom right corner?

Because I tried that and found that it looked pretty damn awful compared to this. :D (Hence the "no viable alternatives").

image

True, I would be fine with changes to the globe icon if that helps.

@ericfennis
Copy link
Member

@karsa-mistmere Really nice icon!
The lock in the right bottom looks a bit better to me.

@karsa-mistmere
Copy link
Member Author

Material Symbols also places the lock in the top right corner:
image

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Oct 6, 2023 •
edited
Loading

A redesign of globe-2 that better allows a bottom right lock icon:
image

To be honest, I still prefer my original proposal. :D

@ericfennis
Copy link
Member

@karsa-mistmere Can you post a 100% scale comparison?

@karsa-mistmere
Copy link
Member Author

image

@jguddas
Copy link
Member

jguddas commented Oct 10, 2023 •
edited
Loading

A globe like this could accommodate things in the bottom right.

@karsa-mistmere
Copy link
Member Author

image

Not sure what you mean?

@ericfennis
Copy link
Member

@jguddas I think you can better post the changed SVG.

@jguddas
Copy link
Member

jguddas commented Oct 13, 2023

icon (19)

https://lucide-site-git-feat-added-edit-page-jguddas.vercel.app/edit?PHN2ZwogIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIKICB3aWR0aD0iMjQiCiAgaGVpZ2h0PSIyNCIKICB2aWV3Qm94PSIwIDAgMjQgMjQiCiAgZmlsbD0ibm9uZSIKICBzdHJva2U9ImN1cnJlbnRDb2xvciIKICBzdHJva2Utd2lkdGg9IjIiCiAgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIgogIHN0cm9rZS1saW5lam9pbj0icm91bmQiCj4KICA8Y2lyY2xlIGN4PSIxMiIgY3k9IjEyIiByPSIxMCIgLz4KICA8cGF0aCBkPSJNMjEuNSAxNUgxN2EyIDIgMCAwIDAtMiAydjQuNSIgLz4KICA8cGF0aCBkPSJNMi4yIDEwSDRhMiAyIDAgMCAxIDIgMnYxYTIgMiAwIDAgMCAyIDIgMiAyIDAgMCAxIDIgMnY0LjgiIC8+CiAgPHBhdGggZD0iTTUuNCA0LjVBMyAzIDAgMCAwIDggN2EyIDIgMCAwIDEgMiAydi41YTIgMiAwIDEgMCA0IDBWOWEyIDIgMCAwIDEgMi0yaDQuNyIgLz4KPC9zdmc+

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Oct 13, 2023 •
edited
Loading

Here's a 100% comparison of all three versions:
image

@ericfennis
Copy link
Member

The second row looks the best to me.

I don't know but it feels a bit nicer with the lock on the bottom. Maybe because the flat bottom side?

What do you think?

@karsa-mistmere
Copy link
Member Author

That's exactly why the first row looks better to me, it has slightly better centre of gravity. :)

jguddas
jguddas reviewed Oct 13, 2023
View reviewed changes
icons/globe-lock.svg Outdated
Comment on lines 12 to 17
<path d="M7 3.34V5a3 3 0 0 0 3 3" />
<path d="M11 21.95V18a2 2 0 0 0-2-2 2 2 0 0 1-2-2v-1a2 2 0 0 0-2-2H2.05" />
<path d="M21.54 15H17a2 2 0 0 0-2 2v4.54" />
<path d="M12 2a10 10 0 1 0 9.54 13" />
<path d="M20 6V4a2 2 0 1 0-4 0v2" />
<rect width="8" height="5" x="14" y="6" rx="1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon - 2023-10-13T213723 981

Suggested change
<path d="M7 3.34V5a3 3 0 0 0 3 3" />
<path d="M11 21.95V18a2 2 0 0 0-2-2 2 2 0 0 1-2-2v-1a2 2 0 0 0-2-2H2.05" />
<path d="M21.54 15H17a2 2 0 0 0-2 2v4.54" />
<path d="M12 2a10 10 0 1 0 9.54 13" />
<path d="M20 6V4a2 2 0 1 0-4 0v2" />
<rect width="8" height="5" x="14" y="6" rx="1" />
<path d="M14 22v-4a1 1 0 0 1 1-1h6a1 1 0 0 1 1 1v3a1 1 0 0 1-1 1h-9" />
<path d="M15.7 9.5A15.3 15.3 0 0 0 12 2a14.5 14.5 0 0 0 0 20 10 10 0 1 1 9.862-11.658" />
<path d="M20 17v-2a2 2 0 1 0-4 0v2" />
<path d="M2 12h10.9" />

@ericfennis
Copy link
Member

@karsa-mistmere I'm ok with that!
@jguddas Do you have a final opinion on this?

@jguddas
Copy link
Member

jguddas commented Oct 17, 2023

@karsa-mistmere I'm ok with that!
@jguddas Do you have a final opinion on this?

What about my proposal, based on globe?

I'm not a super big fan of any of the proposals including mine, quite a lot of compromises.

I definitely think the name has to change if we want to base it on globe-2 rather than globe.

@ericfennis
Copy link
Member

I think the first and second row looks a bit more balanced. Some gaps between some continents looks a bit too big.

I agree on renaming this icon and globe-2 to earth as we discussed in discord.

@jguddas
Copy link
Member

jguddas commented Oct 18, 2023

+1 for row 2

@karsa-mistmere
Copy link
Member Author

karsa-mistmere commented Oct 18, 2023 •
edited
Loading

What about my proposal, based on globe?

I think the first and second row looks a bit more balanced. Some gaps between some continents looks a bit too big.

I think @jguddas means this one:
image

I made two very similar ones, but I'm not a fan of these, the paths are just too broken up:
image

(Although again, the one with the lock in the top right corner is much more balanced).

@github-actions github-actions bot added the Stale label Nov 23, 2023
@jguddas
Copy link
Member

jguddas commented Dec 14, 2023

I don't feel 100% about either option, what about ‘lab‘ing it?

@ericfennis
Copy link
Member

@jguddas Hmm I think the usecase is a valid usecase. I think we just need to agree on the styling.
@karsa-mistmere Can you make a decision, or do you want me to make the decision?

@karsa-mistmere
Copy link
Member Author

@jguddas Hmm I think the usecase is a valid usecase. I think we just need to agree on the styling. @karsa-mistmere Can you make a decision, or do you want me to make the decision?

I still prefer my original design, since it means we don't have to also update globe to match, and I very much prefer our current globe icon to any of the proposed alternates.

@jguddas
Copy link
Member

jguddas commented Dec 24, 2023

I just think it's cramped and not all that pretty.

ericfennis
ericfennis requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I want to move on with this one.
I'm ok with the current design, and I think we should move forward.
I think we should rename globe-2 to earth and call this one earth-lock.
I also think we should add the other globe-lock design. With the globe icon in the background.

@github-actions github-actions bot added the Stale label Feb 17, 2024
@karsa-mistmere
Copy link
Member Author

Ok I want to move on with this one. I'm ok with the current design, and I think we should move forward. I think we should rename globe-2 to earth and call this one earth-lock. I also think we should add the other globe-lock design. With the globe icon in the background.

@ericfennis Done!

@jguddas
Copy link
Member

jguddas commented Feb 25, 2024

I think it should be planet-earth so we keep our selves open for the material type earth.

@karsa-mistmere
Copy link
Member Author

I think it should be planet-earth so we keep our selves open for the material type earth.

Do you mean this one?
image

@karsa-mistmere karsa-mistmere changed the title Added globe-lock icon feat(icons): added globe-lock icon Feb 25, 2024
@jguddas
Copy link
Member

jguddas commented Feb 25, 2024

I think it should be planet-earth so we keep our selves open for the material type earth.

Do you mean this one? image

I mean just instead of calling it earth we should call it planet-earth and planet-earth-lock

@karsa-mistmere
Copy link
Member Author

I think it should be planet-earth so we keep our selves open for the material type earth.

Do you mean this one? image

I mean just instead of calling it earth we should call it planet-earth and planet-earth-lock

Yeah, but what exactly do you mean keep ourselves open for "the material type earth"?

@jguddas
Copy link
Member

jguddas commented Feb 25, 2024

I think it should be planet-earth so we keep our selves open for the material type earth.

Do you mean this one? image

I mean just instead of calling it earth we should call it planet-earth and planet-earth-lock

Yeah, but what exactly do you mean keep ourselves open for "the material type earth"?

https://www.thesaurus.com/browse/earth

@karsa-mistmere
Copy link
Member Author

I think it should be planet-earth so we keep our selves open for the material type earth.

Do you mean this one? image

I mean just instead of calling it earth we should call it planet-earth and planet-earth-lock

Yeah, but what exactly do you mean keep ourselves open for "the material type earth"?

https://www.thesaurus.com/browse/earth

Haha, I totally thought you meant Material as in https://m3.material.io/styles/icons/overview

If and when we add this as an icon, soil or ground would be much more obvious choices for a name, so I think we're in the clear.

@lucide-icons lucide-icons deleted a comment from github-actions bot Feb 25, 2024
@ericfennis
Copy link
Member

Yeah I think just earth is fine.

@ericfennis ericfennis merged commit 148bae8 into main Feb 26, 2024
7 checks passed
@ericfennis ericfennis deleted the icon/globe-lock branch February 26, 2024 08:53
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
@karsa-mistmere @ericfennis
feat(icons): added globe-lock icon (lucide-icons#1587)
af62aad 
* Added globe-lock icon

* feat(icons): Added globe-lock, renamed globe-2 to earth, and added earth-lock

* feat(icons): Added globe as a tag to earth

---------

Co-authored-by: Eric Fennis <[email protected]>
Co-authored-by: Karsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jguddas jguddas jguddas approved these changes

@ericfennis ericfennis ericfennis approved these changes

Assignees

@karsa-mistmere karsa-mistmere

Labels
🎨 icon About new icons 🫧 metadata Improved metadata 🙋‍♂️ opinion wanted Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karsa-mistmere @jguddas @ericfennis