Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jsx type for icons in vue 3 #1617

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

CyanSalt
Copy link
Contributor

Closes #548

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Declaring a component as DefineComponent<Props> can be correctly recognized by the IDE as a JSX element and provide autocompletion of props.

usage

Before Submitting

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! LGTM

@ericfennis ericfennis merged commit 3d0c869 into lucide-icons:main Oct 23, 2023
2 checks passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript annotation in Vue 3 with Vite
2 participants