Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): arcified shrub icon #2292

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Jul 6, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Arcified branches

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Jul 6, 2024
Copy link

github-actions bot commented Jul 6, 2024

Added or changed icons

icons/shrub.svg

Preview cohesion icons/square-dot.svg
icons/shrub.svg
icons/align-left.svg
Preview stroke widths icons/shrub.svg
icons/shrub.svg
icons/shrub.svg
DPI Preview (24px) icons/shrub.svg
Icon X-rays icons/shrub.svg
Icon Diffs icons/shrub.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ShrubIcon = createLucideIcon('Shrub', [
  ["path",{"d":"M12 22V9"}],
  ["path",{"d":"m15.5 14.5-2.914 2.914A2 2 0 0 0 12 18.828"}],
  ["path",{"d":"M17 8.8A6 6 0 0 1 13.8 20H10A6.5 6.5 0 0 1 7 8a5 5 0 0 1 10 0z"}],
  ["path",{"d":"m9 12 2.414 2.414A2 2 0 0 1 12 15.828"}]
])

@karsa-mistmere
Copy link
Member

To be honest, both of these still look very weird when scaled up:
image

What about accentuating the difference between the branches?
image
image

@jguddas
Copy link
Member Author

jguddas commented Jul 9, 2024

I like the accentuated one with 2 branches

@ericfennis
Copy link
Member

I agree with @jguddas, maybe make the right branch a bit longer, how will that look?

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 23, 2024
@karsa-mistmere
Copy link
Member

@ericfennis, @jguddas: LMKWYT

image

image

icons
Open lucide studio

@karsa-mistmere
Copy link
Member

TBH, no arcs looks better (and more consistent) to me than with arcs:

image

@jguddas jguddas closed this Dec 5, 2024
@karsa-mistmere
Copy link
Member

@jguddas We could consider changing the overall look of the icon though (to something that resembles female anatomy a bit less that it currently does :D ):

image

@karsa-mistmere karsa-mistmere reopened this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants