Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added waves-ladder icon #2529

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Oct 12, 2024

Closes #2526

What is the purpose of this pull request?

  • New Icon

Description

Added new ladder-over-wave icon.

Icon use case

Maps, facilities

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Oct 12, 2024
Copy link

github-actions bot commented Oct 12, 2024

Added or changed icons

icons/waves-ladder.svg

Preview cohesion icons/square-terminal.svg
icons/waves-ladder.svg
icons/file-type.svg
Preview stroke widths icons/waves-ladder.svg
icons/waves-ladder.svg
icons/waves-ladder.svg
DPI Preview (24px) icons/waves-ladder.svg
Icon X-rays icons/waves-ladder.svg
Icon Diffs icons/waves-ladder.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const WavesLadderIcon = createLucideIcon('WavesLadder', [
  ["path",{"d":"M19 5a2 2 0 0 0-2 2v11"}],
  ["path",{"d":"M2 18c.6.5 1.2 1 2.5 1 2.5 0 2.5-2 5-2 2.6 0 2.4 2 5 2 2.5 0 2.5-2 5-2 1.3 0 1.9.5 2.5 1"}],
  ["path",{"d":"M7 13h10"}],
  ["path",{"d":"M7 9h10"}],
  ["path",{"d":"M9 5a2 2 0 0 0-2 2v11"}]
])

@ericfennis
Copy link
Member

@jguddas Did you try to detach de ladder from the waves? I'm curious how that will look.

@ericfennis
Copy link
Member

What about the name waves-ladder?

@jguddas jguddas changed the title feat(icons): added ladder-over-wave icon feat(icons): added waves-ladder icon Nov 5, 2024
icons/waves-ladder.json Outdated Show resolved Hide resolved
@karsa-mistmere karsa-mistmere merged commit f12b0de into lucide-icons:main Dec 5, 2024
7 of 8 checks passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
* Added icons/ladder-over-wave.svg

* Added icons/ladder-over-wave.json

* Rename ladder-over-wave.json to waves-ladder.json

* Rename ladder-over-wave.svg to waves-ladder.svg

* Update icons/waves-ladder.json

Co-authored-by: Eric Fennis <[email protected]>

---------

Co-authored-by: Eric Fennis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swimming pool
3 participants