Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added saturn icon #2626

Closed
wants to merge 2 commits into from

Conversation

Footagesus
Copy link

What is the purpose of this pull request?

  • New Icon

Description

Added new saturn icon.

Icon use case

The Saturn icon represents a planet with rings and is used to represent space, astronomy, or futuristic ideas in applications and interfaces.

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @Footagesus
  • I've based them on the following Lucide icons: layers-circle
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 20, 2024
Copy link

Added or changed icons

icons/saturn.svg

Preview cohesion icons/rotate-cw-square.svg
icons/saturn.svg
icons/videotape.svg
Preview stroke widths icons/saturn.svg
icons/saturn.svg
icons/saturn.svg
DPI Preview (24px) icons/saturn.svg
Icon X-rays icons/saturn.svg
Icon Diffs icons/saturn.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const SaturnIcon = createLucideIcon('Saturn', [
  ["path",{"d":"M17.81 10.55A10 2.585 0 0 1 12 15a10 2.585 0 0 1-5.83-4.45"}],
  ["circle",{"cx":"11.994","cy":"12","r":"6"}]
])

@karsa-mistmere
Copy link
Member

Feels far too small and the ring has a gap guideline violation, also duplicates https://lucide.dev/icons/lab/planet

@Footagesus
Copy link
Author

I couldn't find this icon on the site

@karsa-mistmere
Copy link
Member

I couldn't find this icon on the site

It's still in our lab branch, you have to select Lab on the site:
image

The reason it's in lab and not main is exactly why this PR won't either go through as is: it has severe gap guideline violations.

Something like this could work, I guess:

icons
Open lucide studio

@jguddas
Copy link
Member

jguddas commented Nov 20, 2024

I couldn't find this icon on the site

It's still in our lab branch, you have to select Lab on the site: image

The reason it's in lab and not main is exactly why this PR won't either go through as is: it has severe gap guideline violations.

Something like this could work, I guess:

iconsOpen lucide studio

Your version is pretty cute, do we have a good list of use cases for the icon.

The Saturn icon represents a planet with rings and is used to represent space, astronomy, or futuristic ideas in applications and interfaces.

@Footagesus i.e. don't tell me what the icon represents, tell me places where it would be used.

Only "applications and interfaces" is not specific enough.

@Footagesus
Copy link
Author

OK! Thank you

@Footagesus Footagesus closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants