-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(icons): added list-filter-plus
icon
#2645
feat(icons): added list-filter-plus
icon
#2645
Conversation
Added or changed iconsIcons as codeWorks for: const ListFilterPlusIcon = createLucideIcon('ListFilterPlus', [
["path",{"d":"M10 18h4"}],
["path",{"d":"M11 6H3"}],
["path",{"d":"M15 6h6"}],
["path",{"d":"M18 9V3"}],
["path",{"d":"M7 12h8"}]
]) |
I'm not really sold on this design, it kinda looks more like |
With it in the top corner it's better. |
Also, the plus itself is off grid. |
The design seems fine, but let's address Jakob's concern as well as mine about gaps and keeping lines pixel perfect. |
Grid and gap fixes: Edit: use studio embed instead of screenshots |
I believe the middle line still has a gap violation, not exactly sure how the 2px gap violations are handled in a case like this where the gap is not direct between two elements |
Fixed 2px gap violation on the middle line: Edit: use studio embed instead of screenshot |
Hi @jguddas @karsa-mistmere, is there anything further I can work on or improve to get this considered? |
* Added icons/list-filter-plus.svg * Added icons/list-filter-plus.json * Move plus to the top line * Optimize top line and plus gap * Grid alignment and gap fixes * Fix gap violation on middle line * Optimize gap between plus and middle line * Fix pixel perfect * Add category `layout` to metadata
What is the purpose of this pull request?
Description
Added new
list-filter-plus
icon.Icon use case
Use cases:
Alternative icon designs
Icon Design Checklist
Concept
Author, credits & license
list-filter
,list-plus
Naming
icons/[iconName].json
.Design
Before Submitting