Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added list-filter-plus icon #2645

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

abdeniz
Copy link
Contributor

@abdeniz abdeniz commented Nov 27, 2024

What is the purpose of this pull request?

  • New Icon

Description

Added new list-filter-plus icon.

Icon use case

Use cases:

  • Adding column filters to a data table
  • Adding advanced filters

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @abdeniz
  • I've based them on the following Lucide icons: list-filter, list-plus
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Nov 27, 2024
Copy link

github-actions bot commented Nov 27, 2024

Added or changed icons

icons/list-filter-plus.svg

Preview cohesion icons/square-kanban.svg
icons/list-filter-plus.svg
icons/library.svg
Preview stroke widths icons/list-filter-plus.svg
icons/list-filter-plus.svg
icons/list-filter-plus.svg
DPI Preview (24px) icons/list-filter-plus.svg
Icon X-rays icons/list-filter-plus.svg
Icon Diffs icons/list-filter-plus.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ListFilterPlusIcon = createLucideIcon('ListFilterPlus', [
  ["path",{"d":"M10 18h4"}],
  ["path",{"d":"M11 6H3"}],
  ["path",{"d":"M15 6h6"}],
  ["path",{"d":"M18 9V3"}],
  ["path",{"d":"M7 12h8"}]
])

icons/list-filter-plus.svg Outdated Show resolved Hide resolved
@karsa-mistmere
Copy link
Member

I'm not really sold on this design, it kinda looks more like align-right-plus.

@jguddas
Copy link
Member

jguddas commented Nov 27, 2024

With it in the top corner it's better.
There is a gap violation in this version now, needs to be at least 2px between the plus and top line.

@karsa-mistmere
Copy link
Member

karsa-mistmere commented Nov 27, 2024

With it in the top corner it's better. There is a gap violation in this version now, needs to be at least 2px between the plus and top line.

Also, the plus itself is off grid.

@abdeniz
Copy link
Contributor Author

abdeniz commented Nov 27, 2024

I'm not really sold on this design, it kinda looks more like align-right-plus.

It does indeed, I believe moving the plus to the top line eliminates this confusion, although now it does differ from the list-plus icon's plus position. Could something like this work?

image image

image

@karsa-mistmere
Copy link
Member

I'm not really sold on this design, it kinda looks more like align-right-plus.

It does indeed, I believe moving the plus to the top line eliminates this confusion, although now it does differ from the list-plus icon's plus position. Could something like this work?

image image

image

The design seems fine, but let's address Jakob's concern as well as mine about gaps and keeping lines pixel perfect.

@abdeniz
Copy link
Contributor Author

abdeniz commented Nov 27, 2024

Grid and gap fixes:

icons
Open lucide studio

Edit: use studio embed instead of screenshots

@abdeniz
Copy link
Contributor Author

abdeniz commented Nov 27, 2024

I believe the middle line still has a gap violation, not exactly sure how the 2px gap violations are handled in a case like this where the gap is not direct between two elements

@abdeniz
Copy link
Contributor Author

abdeniz commented Nov 27, 2024

Fixed 2px gap violation on the middle line:

icons
Open lucide studio

Edit: use studio embed instead of screenshot

@jguddas
Copy link
Member

jguddas commented Nov 27, 2024

Fixed 2px gap violation on the middle line:

image

image

There is a share > copy GitHub embed, you don't have to paste the screenshot.

@abdeniz
Copy link
Contributor Author

abdeniz commented Dec 3, 2024

Hi @jguddas @karsa-mistmere, is there anything further I can work on or improve to get this considered?

@ericfennis ericfennis merged commit ea89735 into lucide-icons:main Dec 5, 2024
8 checks passed
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
* Added icons/list-filter-plus.svg

* Added icons/list-filter-plus.json

* Move plus to the top line

* Optimize top line and plus gap

* Grid alignment and gap fixes

* Fix gap violation on middle line

* Optimize gap between plus and middle line

* Fix pixel perfect

* Add category `layout` to metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants