-
-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lucide package for Astro #2665
base: main
Are you sure you want to change the base?
Conversation
Added or changed iconsIcons as codeWorks for: const PictureInPictureIcon = createLucideIcon('PictureInPicture', [
["path",{"d":"M2 10h6V4"}],
["path",{"d":"m2 4 6 6"}],
["path",{"d":"M21 10V7a2 2 0 0 0-2-2h-7"}],
["path",{"d":"M3 14v2a2 2 0 0 0 2 2h3"}],
["rect",{"width":"10","height":"7","x":"12","y":"14","rx":"1"}]
]) |
], | ||
"aliases": [ | ||
"grid-2-x-2-check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this was added by the script that previously didn't run.
Yeah it's definitely bigger than the other icons, I'll fix that @realguse |
Remember to also update the table in the main readme as well, nice work whatsoever though! |
Well shoot, I just realized We could just rename the package to something like Pinging @ericfennis just in case he (or anyone) has recommendations/ideas on what we could do. |
Hi, I'm the current owner of
What do you think about these ? |
Thank you for your response and willingness. We are more than happy to meet your conditions:
Let us know if there's anything else you'd like us to address before proceeding. |
I'm happy with the current elements ! As soon as the new lib feels ready for you, I can check it on my current projects to validate it and then transfer the ownership to the group so you can continue publishing it ! I'll also wait for the confirmations from the admins of the repo |
That sounds great! Thank you so much again! In my eyes this looks very much ready, so if we could get @ericfennis to accept this then you guys can go ahead and start the transfer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add astro pkg label to .github/labeler.yml
Sorry for the late response y'all. I've been quite busy this week unfortunately. Btw thanks so much @realguse for chiming in and taking the lead, and thanks @Aviortheking for your willingness. As @realguse said, we're happy to meet your conditions! |
b4657ae
to
6a57cd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add lucide-astro option in the feature request and bug report issue templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MoustaphaDev Concrats, really well done!!
This package is welcome to the stack.
Nice you reused all the utilities and build tooling.
I'm fine with taking over the name of lucide-astro
.
We eventually want to move to scoped packages @lucide/*
, but not sure if this is the time.
So let's check what we need to do before merging this.
TODOs:
- Manual testing package on an Astro project
- Transfer NPM package to me
ericfennis
- Revert changes in
/icons/*
- Reviewing docs
- Release a RC, to check if working with older projects
Sorry don't know what happend there, i meant revert the |
TODOs:
What is the purpose of this pull request?
Description
Add a new package for first-class Astro support.
Before Submitting