Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lucide package for Astro #2665

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

MoustaphaDev
Copy link

@MoustaphaDev MoustaphaDev commented Dec 5, 2024

TODOs:

  • lucide-astro package
  • Testing
  • Docs page
  • Framework logo
  • Homepage icon
  • Package logo (both light and dark)
  • Add "Lucide Astro" in the left sidebar
  • Add workflows for package publishing and testing

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Add a new package for first-class Astro support.

Before Submitting

@github-actions github-actions bot added the 📦 dependencies Pull requests that update a dependency file label Dec 5, 2024
@MoustaphaDev MoustaphaDev marked this pull request as draft December 5, 2024 21:07
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Added or changed icons

icons/picture-in-picture.svg

Preview cohesion icons/square-library.svg
icons/picture-in-picture.svg
icons/file-cog.svg
Preview stroke widths icons/picture-in-picture.svg
icons/picture-in-picture.svg
icons/picture-in-picture.svg
DPI Preview (24px) icons/picture-in-picture.svg
Icon X-rays icons/picture-in-picture.svg
Icon Diffs icons/picture-in-picture.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const PictureInPictureIcon = createLucideIcon('PictureInPicture', [
  ["path",{"d":"M2 10h6V4"}],
  ["path",{"d":"m2 4 6 6"}],
  ["path",{"d":"M21 10V7a2 2 0 0 0-2-2h-7"}],
  ["path",{"d":"M3 14v2a2 2 0 0 0 2 2h3"}],
  ["rect",{"width":"10","height":"7","x":"12","y":"14","rx":"1"}]
])

Comment on lines +29 to +31
],
"aliases": [
"grid-2-x-2-check"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was added by the script that previously didn't run.

@github-actions github-actions bot added 📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website labels Dec 6, 2024
@MoustaphaDev
Copy link
Author

Yeah it's definitely bigger than the other icons, I'll fix that @realguse

@realguse
Copy link
Contributor

realguse commented Dec 7, 2024

Remember to also update the table in the main readme as well, nice work whatsoever though!

@MoustaphaDev
Copy link
Author

MoustaphaDev commented Dec 8, 2024

Well shoot, I just realized lucide-astro is already taken on npm.

We could just rename the package to something like lucide-astrojs, however Astro dropped the "dot js" part from its branding long ago. Or we could kindly ask to be given ownership of it.

Pinging @ericfennis just in case he (or anyone) has recommendations/ideas on what we could do.

@Aviortheking
Copy link
Contributor

Hi, I'm the current owner of lucide-astro I'm totally not against moving the ownership of the package to you !
I would just want to make sure of 2-3 things :

  1. The package keep old versions
  2. the package is backward-compatible with previous version
  3. (Optional but appreciated) a ref of the previous maintainer of the package

What do you think about these ?

@realguse
Copy link
Contributor

realguse commented Dec 9, 2024

Thank you for your response and willingness. We are more than happy to meet your conditions:

  • We'll ensure that all existing versions remain available on npm.

  • The package will maintain backward compatibility with the current implementation.

  • We'll also include a reference to you as the original maintainer in the README and/or changelg.

Let us know if there's anything else you'd like us to address before proceeding.

@Aviortheking
Copy link
Contributor

Aviortheking commented Dec 9, 2024

I'm happy with the current elements !

As soon as the new lib feels ready for you, I can check it on my current projects to validate it and then transfer the ownership to the group so you can continue publishing it !

I'll also wait for the confirmations from the admins of the repo

@realguse
Copy link
Contributor

realguse commented Dec 9, 2024

That sounds great! Thank you so much again! In my eyes this looks very much ready, so if we could get @ericfennis to accept this then you guys can go ahead and start the transfer

Copy link
Contributor

@realguse realguse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add astro pkg label to .github/labeler.yml

@MoustaphaDev
Copy link
Author

Sorry for the late response y'all. I've been quite busy this week unfortunately.

Btw thanks so much @realguse for chiming in and taking the lead, and thanks @Aviortheking for your willingness.

As @realguse said, we're happy to meet your conditions!
I'll try to get this over the line this weekend when I have some time.

Copy link
Contributor

@realguse realguse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add lucide-astro option in the feature request and bug report issue templates

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MoustaphaDev Concrats, really well done!!
This package is welcome to the stack.
Nice you reused all the utilities and build tooling.

I'm fine with taking over the name of lucide-astro.
We eventually want to move to scoped packages @lucide/*, but not sure if this is the time.

So let's check what we need to do before merging this.

TODOs:

  • Manual testing package on an Astro project
  • Transfer NPM package to me ericfennis
  • Revert changes in /icons/*
  • Reviewing docs
  • Release a RC, to check if working with older projects

realguse

This comment was marked as spam.

@realguse
Copy link
Contributor

realguse commented Dec 22, 2024

Sorry don't know what happend there, i meant revert the icons/picture-in-picture.svg, icons/grid-2x2-x.json and icons/grid-2x2-check.json. Done in MoustaphaDev#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 dependencies Pull requests that update a dependency file 📖 documentation Improvements or additions to documentation 🎨 icon About new icons 🫧 metadata Improved metadata 🌍 site Has to do something with the Lucide website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants