-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Various typographical error fixes and improvements in the English usage #322
[MAINTENANCE] Various typographical error fixes and improvements in the English usage #322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Although, I wonder if we should move contributing.md
from main ludwig to ludwig docs, and then point to the ludwig docs contributing.md from the main ludwig repo. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@arnavgarg1 Before I merge, let us discuss. I kept it in the code repository using the logic that contributing is closer to code than documentation. I am not sure which is the best way; what is the reason for your recommendation that it be kept in the documentation repository? Thanks. |
Btw, you will also need to edit |
@alexsherstinsky got it! I think that's reasonable actually, we can leave it in the main Ludwig repo. |
@arnavgarg1 I thought that I did that -- could you please double check to make sure I did not miss it? Thanks! |
Oh I see it now, sorry about that! |
@arnavgarg1 Not at all -- really appreciate doing the rechecking. Is there a way to view the "staged" content of the pull request, before I merge? Something like Netlify perhaps? Thanks! |
Scope