Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't start dnsmasq if all of #1544

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Don't start dnsmasq if all of #1544

wants to merge 3 commits into from

Conversation

alex14641
Copy link 

dns.mode == none
ipv4.address == none || ipv4.dhcp == false
ipv6.address == none

Fixes #1537

@alex14641
Don't start dnsmasq if all of
587e698 
    dns.mode == none
    ipv4.address == none || ipv4.dhcp == false
    ipv6.address == none

Signed-off-by: Alex Davis <[email protected]>
@alex14641 alex14641 requested a review from stgraber as a code owner December 23, 2024 23:11
@alex14641
Copy link
Author

I'm seeing the error "internal/server/network/driver_bridge.go:2694: File is not gci-ed with --skip-generated -s standard -s default -s". Is this something I need to fix? If so how?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incus starts dnsmasq on bridge even if dns.mode none and ipv[46].dhcp false
1 participant
@alex14641