Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Functionality added for Object/Arrays along with Icon #256

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ahmedkhan1039
Copy link

@ahmedkhan1039 ahmedkhan1039 commented Apr 30, 2019

Select Icon Added for Selecting Variables, Arrays, Objects. The icon will show normally besides the add or delete icon.

Kindly review this and let me know if i need to do anything else. Otherwise, please merge the request as soon as possible.

@mac-s-g
Copy link
Owner

mac-s-g commented Jul 16, 2019

thanks for contributing! I can review this week. sorry for the delay on feedback!

@ahmedkhan1039
Copy link
Author

@mac-s-g Thanks for responding. Please let me know if i need to change something.

@ahmedkhan1039
Copy link
Author

@mac-s-g Please review this PR and let me know if i need to change anything

@mac-s-g
Copy link
Owner

mac-s-g commented Jan 25, 2021

@ahmedkhan1039 sorry to leave you hanging.
This project has been inactive for a while, but we're getting back up to speed with additional maintainers.

There were some significant updates recently that are causing merge conflicts, but the code looks good to me.

thanks for sharing. I'll look into getting the merge conflicts resolved.

@ahmedkhan1039
Copy link
Author

Thanks @mac-s-g . Should i resolve the conflicts or you will do it on your end ?

@ahmedkhan1039
Copy link
Author

@mac-s-g Please merge my branch . All conflicts are resolved and checks are passing

@jitendra-kr
Copy link

Hi @mac-s-g When you are planning to make this project active ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants