Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed filters of aggregations query in PLP #4362

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

del22123
Copy link
Collaborator

Description

This PR contains the fix for Layered navigation empty filter options

Closes #PWA-3363
https://jira.corp.adobe.com/browse/PWA-3363

Acceptance

Verification Stakeholders

Specification

Verification Steps

Step 1: Navigate to PLP page
Step 2: Apply few filters
Step 3: Verify the options in layered navigations
(Options should not have any empty items)

Current result:
Empty option items are shown

Fix result:
Empty option items will be removed

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Dec 11, 2024

Fails
🚫

node failed.

🚫 A version label is required. A maintainer must add one.
🚫

Unit tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • packages/peregrine/lib/talons/RootComponents/Category/__tests__/useCategoryContent.spec.js
Messages
📖

Associated JIRA tickets: PWA-3363.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against a52f259

glo82145
glo82145 previously approved these changes Dec 17, 2024
Copy link
Collaborator

@glo82145 glo82145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the failing PR test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants